> -----Original Message-----
> From: stefan2_at_apache.org [mailto:stefan2_at_apache.org]
> Sent: zaterdag 19 april 2014 14:44
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1588651 - in
> /subversion/trunk/subversion/libsvn_fs_fs: caching.c fs.c fs_fs.h
>
> Author: stefan2
> Date: Sat Apr 19 12:44:07 2014
> New Revision: 1588651
>
> URL: http://svn.apache.org/r1588651
> Log:
> Reduce the size of an FSFS instance by using temporary pools
> for temp. data during fs_open().
>
> * subversion/libsvn_fs_fs/fs_fs.h
> (svn_fs_fs__initialize_caches): Document that the POOL shall be
> used for temporaries only.
>
> * subversion/libsvn_fs_fs/caching.c
> (svn_fs_fs__initialize_caches): Fix the only place where we used
> POOL instead of FS->POOL for
> something with svn_fs_t lifetime.
>
> * subversion/libsvn_fs_fs/fs.c
> (fs_serialized_init): Document POOL usage that we will now rely on.
> (fs_open): Use a SUBPOOL for anything temporary during FS init.
+1
(Haven't reviewed all details, but the change looks good)
Usually I rename relevant arguments of inner functions to scratch_pool (sometimes leaving a local variable with the old name) to make its use directly clear in every usage without relying on outside documentation.
Bert
Received on 2014-04-19 14:56:38 CEST