Re: svn commit: r1586947 - in /subversion/trunk/subversion/libsvn_fs_fs: dag.c dag.h tree.c
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 14 Apr 2014 09:23:18 +0100 (BST)
Bert Huijben wrote:
It seems the main problem here is simply that this log message summary line gives a false impression about the magnitude of this particular change.
>> Error objects are a very expensive way to control the control flow
I totally support this particular kind of change. It's simply good interface design.
p.s. A minor commenting nit...
>> Modified: subversion/trunk/subversion/libsvn_fs_fs/tree.c
That comment there is now redundant ...
>> - if (err && err->apr_err == SVN_ERR_FS_NOT_FOUND)
... as this one has now gone away.
>> - SVN_ERR(err);
This is an archived mail posted to the Subversion Dev mailing list.