RE: svn commit: r1585921 - /subversion/trunk/subversion/include/svn_error.h

> -----Original Message-----
> From: julianfoad_at_apache.org [mailto:julianfoad_at_apache.org]
> Sent: woensdag 9 april 2014 11:46
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1585921 -
> /subversion/trunk/subversion/include/svn_error.h
>
> Author: julianfoad
> Date: Wed Apr 9 09:45:41 2014
> New Revision: 1585921
>
> URL: http://svn.apache.org/r1585921
> Log:
> * subversion/include/svn_error.h
> (svn_error_root_cause): Document that the returned error should not
> be cleared, just like in svn_error_find_cause.

As all the errors in a chain are in the same pool, clearing the root cause or the complete chain is really the same thing

But it is probably safer to document it this way... as it is certainly wrong to clear both chains.

In most cases it is safer to check for an error somewhere in the chain as what is returned as the root cause (the most inner error) is not really the error that caused the error when error chains are composed. Perhaps we should also extend the documentation to explain this bit.

        Bert
Received on 2014-04-09 13:44:37 CEST