[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Review of lock-many API

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 8 Apr 2014 14:43:45 +0100 (BST)

Philip Martin wrote:

> Julian Foad <julianfoad_at_btopenworld.com> writes:
>> For example: The reader may not be thinking immediately about the two
>> callers named here, having come here from one of the (at the time of
>> writing) six other direct callers. Two of those don't have a
>> result_pool as such and don't clear the error as such.
> There are only four functions in the public API that take accept
> svn_fs_lock_callback_t and they all take a result pool.

Yes. The other two were private functions, only one of which still exists now. The docs are for maintainers of the internals as well as for external users. I guess you think I'm being too fussy/pedantic/prescriptive. OK, maybe I am. We can drop this. I trust you won't mind if I make a few such tweaks at some point sooner or later.

- Julian
Received on 2014-04-08 15:44:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.