[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] svnadmin freeze r1 svnadmin freeze r2 rsync -a ./

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 7 Apr 2014 08:55:10 +0000

Is this a good idea? ---

[[[
Test that 'svnadmin freeze' is nestable.

This would be useful in practice as a means to easily freeze a (small)
number of repositories simultaneously. It also verifies that 'freeze'
doesn't take system-global locks.

Incidentally, this is also the first 'svnadmin freeze' test in our tree.

* subversion/tests/cmdline/svnadmin_tests.py
  (freeze_freeze): New test.
  (test_list): Run it.
]]]

[[[
Index: subversion/tests/cmdline/svnadmin_tests.py
===================================================================
--- subversion/tests/cmdline/svnadmin_tests.py (revision 1585428)
+++ subversion/tests/cmdline/svnadmin_tests.py (working copy)
@@ -2397,6 +2397,14 @@ def verify_packed(sbox):
   svntest.actions.run_and_verify_svnadmin(None, expected_output, [],
                                           "verify", sbox.repo_dir)
 
+def freeze_freeze(sbox):
+ "svnadmin freeze svnadmin freeze (some-cmd)"
+ sbox.build(create_wc=False)
+ second_repo_dir, _ = sbox.add_repo_path('backup')
+ svntest.main.run_svnadmin('freeze', sbox.repo_dir, '--',
+ svntest.main.svnadmin_binary, 'freeze', second_repo_dir, '--',
+ sys.executable, '-c', 'True')
+
 ########################################################################
 # Run the tests
 
@@ -2442,6 +2450,7 @@ test_list = [ None,
               load_ignore_dates,
               fsfs_hotcopy_old_with_propchanges,
               verify_packed,
+ freeze_freeze,
              ]
 
 if __name__ == '__main__':
]]]

On re-reading the code, I wonder if I should add read_only=True to
sbox.create().. this would cause the code to freeze the shared read-only
repository, which shouldn't affect other tests in any way except perhaps
to slow them down (when BDB is in use).
Received on 2014-04-07 10:55:55 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.