Re: [PATCH/RFC] Lock refreshing problem in Subversion DAV layer

Sergey Raevskiy <sergey.raevskiy_at_visualsvn.com> writes:

> What actually happens here: Excel tries to refresh existing lock using
> an "If" header (see section 7.8 of RFC 2518 [1]). The supplied lock
> token is valid but server responds with '412 Precondition Failed'
> instead of '200 OK'. Excel tries to obtain a new lock on opened file,
> but request expectedly fails.

I see the same problem with LibreOffice on Linux.

> After some digging, I found out that correct behaviour was broken in
> r859583 [2]
> when fixing issue 2275 [3].

> +@XFail()
> +@SkipUnless(svntest.main.is_ra_type_dav)
> +def dav_lock_refresh(sbox):
> + "refresh timeout of DAV lock"
> +
> + # Around trunk_at_1581815 refreshing of DAV lock fails with error
> + # '412 Precondition Failed'

You say it starts to fail at r859583 so how is 1581815 relevant?

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*