[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r1344347 - stream buffering in config_file.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 3 Apr 2014 19:15:07 +0100 (BST)

>> URL: http://svn.apache.org/viewvc?rev=1344347&view=rev

>> Log:
>> Remove about 15% of the cpu overhead of svnserve and httpd while running
>> the test suite by introducing a very simple parser buffer in the config file
>> parser code.
[...]
>>† * subversion/libsvn_subr/config_file.c
>> †† (parse_context_t): Add buffer and position variables. Use EOF as no
>> ungetc var.
[...]
>>† Modified: subversion/trunk/subversion/libsvn_subr/config_file.c
>> ==============================================================================
>>† +
>>† +† /* Parser buffer for getc() to avoid call overhead into several libraries
>>† +† †† for every character */
>>† +† char parser_buffer[SVN_STREAM_CHUNK_SIZE];
[...]

This commit implements buffering of a generic stream, directly in the config file parser. Would it not be better to implement buffering of a generic stream as a generic module?

- Julian
Received on 2014-04-03 20:18:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.