[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1582845 - /subversion/trunk/subversion/libsvn_fs/fs-loader.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 28 Mar 2014 19:57:28 +0000

"Bert Huijben" <bert_at_qqmail.nl> writes:

>> + expiration_date, steal_lock, pool, pool);
>> +
>> + if (apr_hash_count(results))
>
> Is this function explicitly documented to always set the results value
> on all error paths?
>
> I don't see that in the documentation for svn_fs_lock2?

It is now.

> And it is certainly not our standard pattern for public
> functions... By default the output arguments are undefined on error.

It's necessary to allow the caller to handle all the errors.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2014-03-28 20:58:06 CET

This is an archived mail posted to the Subversion Dev mailing list.