[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1577280 [1/3] - in /subversion/trunk: ./ notes/ subversion/include/ subversion/include/private/ subversion/libsvn_client/ subversion/libsvn_fs/ subversion/libsvn_fs_base/ subversion/libsvn_fs_fs/ subversion/libsvn_fs_x/ subversion/libsvn_r...

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 26 Mar 2014 17:39:34 +0000

Julian Foad <julianfoad_at_btopenworld.com> writes:

> Hi Philip...
>
>> URL: http://svn.apache.org/r1577280
>> Log:
>> Merge the fsfs-lock-many branch to trunk.  [...]
>
>> * subversion/include/svn_fs.h
>>   (svn_fs_lock_target_t, svn_fs_lock_result_t,
>>    svn_fs_lock2, svn_fs_unlock2): new.
>>
>> * subversion/include/svn_repos.h
>>   (svn_repos_fs_lock2, svn_repos_fs_unlock2): new.
>
> Do we intend to deprecate the old versions? If not, then it would be
> better to name the new functions something like ...lock_many() instead
> of ...lock2().

I'm unsure. In some ways it is convenient to have a single path
function as it avoids the need to construct hashes and the error
handling is simpler and less prone to leak. On the other hand when
svn_client_copy4 introduced multi-path copy source the single path
version was deprecated.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2014-03-26 18:40:16 CET

This is an archived mail posted to the Subversion Dev mailing list.