[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1577082 - /subversion/trunk/subversion/tests/cmdline/special_tests.py

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 13 Mar 2014 12:58:52 +0100

> -----Original Message-----
> From: Philip Martin [mailto:philip.martin_at_wandisco.com]
> Sent: donderdag 13 maart 2014 12:32
> To: Bert Huijben
> Cc: dev_at_subversion.apache.org
> Subject: Re: svn commit: r1577082 -
> /subversion/trunk/subversion/tests/cmdline/special_tests.py
>
> "Bert Huijben" <bert_at_qqmail.nl> writes:
>
> >> -----Original Message-----
> >> From: philip_at_apache.org [mailto:philip_at_apache.org]
> >> Sent: donderdag 13 maart 2014 11:13
> >> To: commits_at_subversion.apache.org
> >> Subject: svn commit: r1577082 -
> >> /subversion/trunk/subversion/tests/cmdline/special_tests.py
> >>
> >> Author: philip
> >> Date: Thu Mar 13 10:12:50 2014
> >> New Revision: 1577082
> >>
> >> URL: http://svn.apache.org/r1577082
> >> Log:
> >> Add an XFAIL regression test for issue 4479, multiline svn:special
> truncated.
> >>
> >> * subversion/tests/cmdline/special_tests.py
> >> (multiline_special): New test.
> >> (test_list): Add new test.
> >
> > As far as I can tell we handled this limitation as 'as designed' when
> > implementing WC-NG.
> >
> > I don't think this is something we can really 'fix', as older clients
> > will just break things when they would find such a 'symlink'.
> >
> > The idea back then (ask gstein :-) was to move away from using a
> > single magic property for this, if we ever wanted to support more
> > 'special' files.
>
> If the pristine file for an svn:special is "foo\nbar\n" we currently
> create a working file containing "foo". Irrespective of future changes
> I think it would be better if the working file contained "foo\nbar\n".
> Are you saying that is not a good idea? In what way will old clients
> break?

The WC-NG idea was to stop creating files for symlinks (aka special) and
introduce a proper symlink type in the working copy (and via editor v2),
which would still be handled via the special property trick on commit/update
when using editor v1.

We never really supported multi line svn:special files or really anything
except symlinks... and the idea back then was to never start supporting
those cases either.

        Bert
Received on 2014-03-13 12:59:39 CET

This is an archived mail posted to the Subversion Dev mailing list.