Re: svn commit: r1577079 - in /subversion/trunk/subversion: include/private/ libsvn_client/ libsvn_delta/ libsvn_diff/ libsvn_fs_fs/ libsvn_ra/ libsvn_repos/ libsvn_subr/ libsvn_wc/ svndumpfilter/

On 13 March 2014 14:28, Bert Huijben <bert_at_qqmail.nl> wrote:
>>
>> +/* Sort APR array @a array using ordering defined by @a comparison_func.
>> + * @a comparison_func is defined as for the C stdlib function qsort().
>> + */
>> +void
>> +svn_sort__array(apr_array_header_t *array,
>> + int (*comparison_func)(const void *,
>> + const void *));
>
> I think the documentation should note that the array values must be pointers as that is how you pass the comparison function.
>
> There are pretty common cases where we use apr arrays with struct members, instead of pointer to struct. (E.g. for property changes)
>

Why? svn_sort__array() as qsort() invoke ordering callback with a
pointer to array element. It could pointer to pointer if array
contains pointer or pointer to any struct.

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com