RE: [PATCH]: fix check-mime-type.pl for changes to 'svnlook proplist' output

Hello,

Another approach is to dump 'svnlook proplist' altogether and use 'svnlook propget svn:mime-type' and 'svnlook propget svn:eol-style' instead. That could be maximally backward compatible without introducing XML.

Regards,

Leo
________________________________________
From: Ben Reser <ben_at_reser.org>
Sent: Sunday, March 02, 2014 11:40 PM
To: Leo Davis; Daniel Shahaf
Cc: dev_at_subversion.apache.org
Subject: Re: [PATCH]: fix check-mime-type.pl for changes to 'svnlook proplist' output

On 3/2/14, 5:34 PM, Leo Davis wrote:
> As Ben pointed out, the current parser in the script for svnlook <= 1.7.x is broken and unfixable for multiline properties. The closest we can get to DTRT in this case is to have svnlook output XML. Hopefully no one still cares about svnlook <= 1.3 (?) that cannot output XML.
>
> On Mar 2, 2014, at 8:11 AM, "Daniel Shahaf" <d.s_at_daniel.shahaf.name> wrote:
>> One more issue: however you change the parser, it will break if
>> svnlook1.7 or older is used. It would be nice to DTRT in that case
>> (either error out or retain the old parser).

It would be nice to have, but I think the effort to provide it is just too
great unless we go down the XML path. Which is a pretty large change in the
requirements of the script.

Anyone that wants it can go get a copy of the script off the 1.7.x branch
(assuming we merge the fix to the 1.8.x branch). This is contrib we have no
compatibility guarantees to worry about either.

Just put a prominent notice at the top of the script saying that it is only
intended for use with 1.8.x or newer servers.
Received on 2014-03-03 17:13:06 CET