[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: fix check-mime-type.pl for changes to 'svnlook proplist' output

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 2 Mar 2014 15:10:43 +0000

Ben Reser wrote on Fri, Feb 28, 2014 at 19:07:37 -0800:
> On 2/25/14, 4:21 PM, Leo Davis wrote:
> > I recently discovered that the old 'check-mime-type.pl' contrib script is I
> > had installed on my server was broken when using subversion 1.8.5. I looked
> > for an updated script in the 1.8.5 branch and in trunk and discovered the
> > script was also broken in those places as well. After some digging, I found
> > out when this change happened and patched the script. I suspect (but don't
> > know for sure) that this only affects subversion 1.8.x.
> >
> > This patch is from trunk.
> >
> > [[[
> > Fix check-mime-type.pl for output changes to 'svnlook proplist'.
> >
> > The output format of 'svnlook proplist' was changed in revision 1416637.
> >
> > See also http://svn.haxx.se/dev/archive-2012-11/0510.shtml
> >
> > * contrib/hook-scripts/check-mime-type.pl: Fix reading process output from
> > 'svnlook proplist'.
> > ]]]
>
> First of all thanks for your contribution. You're quite right that this is
> broken for 1.8.x and trunk.
>
> Unfortunately, your patch isn't quite right either.
>
> [description of parsing problems]

One more issue: however you change the parser, it will break if
svnlook1.7 or older is used. It would be nice to DTRT in that case
(either error out or retain the old parser).
Received on 2014-03-02 16:11:41 CET

This is an archived mail posted to the Subversion Dev mailing list.