[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fsfs-stats potentially busted on some architectures

From: Ben Reser <ben_at_reser.org>
Date: Thu, 20 Feb 2014 11:00:55 -0800

On 2/20/14, 3:13 AM, Branko Čibej wrote:
> On 20.02.2014 12:08, Stefan Fuhrmann wrote:
>> On Thu, Feb 20, 2014 at 3:13 AM, Branko Čibej <brane_at_wandisco.com> wrote:
>>> FWIW, I'd be fine with replacing all ints with apr_int32_t in places where
>>> we interact with apr_array_header_t and similar. Widening promotions to int
>>> would be automatic, and narrowing conversions on 16-bit platforms would
>>> (presumably) make compilers yell very loudly.
>> I assume you mean in the SVN code, i.e. at least
>> replace all "(int)"-style casts and then get most of
>> the other places by tedious search-for-APR-macro-
>> and-find-index-variable-declaration.
>> That would be fine with me.
> Yup, that's what I meant. Use an explicitly 32-bit signed type in our code
> instead of casting to int all over the place.

Seems like a reasonable course of action to me. But we're still going to have
casts because of our use in apr_size_t in some APIs.
Received on 2014-02-20 20:01:24 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.