[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fsfs-stats potentially busted on some architectures

From: Branko Čibej <brane_at_wandisco.com>
Date: Thu, 20 Feb 2014 03:13:13 +0100

On 20.02.2014 02:52, Ben Reser wrote:
> On 2/19/14, 5:30 PM, Branko Čibej wrote:
>> 3) Do nothing. Trying to support 16-bit architectures is futile. No-one will
>> host Subversion servers on microcontrollers.
> I'm perfectly fine with that decision. I just wanted some feedback before I
> hid the limitation with a typecast.

FWIW, I'd be fine with replacing all ints with apr_int32_t in places
where we interact with apr_array_header_t and similar. Widening
promotions to int would be automatic, and narrowing conversions on
16-bit platforms would (presumably) make compilers yell very loudly.

The only reason /not/ to do that is marginally worse performance on some
64-bit platforms.

-- Brane

Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane_at_wandisco.com
Received on 2014-02-20 03:14:02 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.