[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.8.8 up for testing/signing

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 19 Feb 2014 08:04:53 +0000 (GMT)

Ben Reser wrote:

> On 2/18/14, 12:22 PM, Johan Corveleyn wrote:
>> Thanks for the hint. Now, this wasn't an error path (just a commit
>> that should have succeeded and should've written something to stdout).
>> I'm not sure how I can determine that this is the likely cause ... I
>> can't seem to reproduce it, no matter how hard I try :-(.
> I unfortunately don't have any good suggestions.  However, I'm assuming we made
> the change to flush stdout when there wasn't an error for some good reason.

Just to be clear about the change <http://svn.apache.org/r1543868> and the reason for it, the change is to flush stdout explicitly before exit rather than implicitly at exit, and the reason is to consistently report if the flush fails. From the log message:

"in order
to report consistently if any information written to standard output is
being lost.

Standard output would be flushed on exit anyway, but this makes sure that
output is not silently lost if it [the flush] fails. We will get both an error message
on stderr and a non-zero exit code."

Previously, in contrast to an error in any other print or flush, if an error occurred in the final flush (during the C run-time exit) then svn exited successfully.

- Julian
Received on 2014-02-19 09:08:37 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.