[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix recover/hotcopy erroring out for old FSFS repositories

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Tue, 18 Feb 2014 03:10:32 +0400

> Here is the fixup for the problem I was talking about in
> http://svn.haxx.se/dev/archive-2014-01/0160.shtml and partially in
> http://svn.haxx.se/dev/archive-2014-01/0089.shtml

I had some time to think about this patch and so, here is a reroll.

The recover_get_root_offset() function from the previous version of this patch
has some problems in it. It was written the same way as the existing
get_root_changes_offset() function from subversion/libsvn_fs_fs/cached_data.c,
however, the get_root_changes_offset() itself has some problems. The problems
I am talking about aren't really the "bang you're dead" kind of problems, but,
as long as we are implementing a new helper, we might as well do it the best way
possible. This V2 patch solves the following issues in V1:

- It avoids seeking to a negative offset for the scenarios when the revision
  file is smaller than buffer (we're in the middle of the recovery procedure,
  so the repository might be in any possible state).

- It avoids touching internal svn_stringbuf_t fields (such as DATA and LEN)
  and achieves the wanted behavior using the stringbuf API only.

- Relying on the allocator-specific BLOCKSIZE when determining the buffer size
  for the trailer is not the best thing to do. In a theoretical case where the
  allocator allocates huge 2KiB blocks for every stringbuf, we would fail to
  parse the trailer for smaller (< 2KiB) revision files.

- svn_io_file_read(), as opposed to svn_io_file_read_full2(), can read any
  number of bytes <= NBYTES before exiting. This essentially means we
  would fail to parse the revision trailer in all scenarios where this function
  returns without filling the buffer.

There are no changes apart from mentioned above.

Evgeny Kotkov

Received on 2014-02-18 00:11:25 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.