[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] pager support for command line client

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 4 Feb 2014 15:15:06 +0000

Ben Reser wrote on Mon, Feb 03, 2014 at 23:36:15 -0800:
> A lot of these will make a lot more sense if we can reasonably default to
> something like the FRSX option set that git passes to less by default. They do
> this by setting the LESS environment variable (if not already set and the pager
> has no arguments).

The way they do it is broken except when $LESS is unset. When it is
set, the user-configured envvar is ignored (so, for me, -i[1] doesn't
get added) and the flags that git's use needs (e.g. -R) are not added.

They should be enabling the -FSRX options without overriding anything
else the user has enabled in $LESS. (Possibly that's just running 'less
-FSRX' or 'less -!F -!S -!R -!X' or something, and leaving the envvar


[1] Makes /-searches case-insensitive.

> In our case I'd suggest FX. I guess R doesn't do much for
> us at this point since we don't emit color codes and S seems like a bad idea
> for a default.
Received on 2014-02-04 16:15:46 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.