Re: Review of initial changes towards normalization-independent lookup

On Sun, Feb 2, 2014 at 1:59 AM, Branko Čibej <brane_at_wandisco.com> wrote:

> On 01.02.2014 11:35, Stefan Fuhrmann wrote:
> > On Wed, Jan 29, 2014 at 12:28 AM, Branko Čibej <brane_at_wandisco.com>
> wrote:
> >
> >> Hi Stefan,
> >>
> >> I'd appreciate a review of my changes in r1562172 and the fixes in
> >> r1562210. Note that this is not a complete implementation, I still have
> to
> >> get (at least) dag.c and tree.c into shape; but I'd appreciate an expert
> >> opinion on whether the approach I chose is sane.
> >>
> > Here we go. It's all minor style / consistency findings.
>
> Thanks! Fixed in r1563534, along with a couple additional style tweaks.
>

Looks good so far. Haven't run the code, though.

-- Stefan^2.
Received on 2014-02-02 14:23:10 CET