[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Review of initial changes towards normalization-independent lookup

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Sat, 1 Feb 2014 05:49:13 +0100

On Wed, Jan 29, 2014 at 12:28 AM, Branko ─îibej <brane_at_wandisco.com> wrote:

> Hi Stefan,
> I'd appreciate a review of my changes in r1562172 and the fixes in
> r1562210. Note that this is not a complete implementation, I still have to
> get (at least) dag.c and tree.c into shape; but I'd appreciate an expert
> opinion on whether the approach I chose is sane.

Hi Brane,

I just reviewed your patches while being sick in Brussels. The only
problem that I found in the first patch got fixed with the second.
There are only a few minor style / comment update bits that I will
list later today.

Your overall approach makes a lot of sense.

-- Stefan
Received on 2014-02-01 05:49:55 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.