[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1547035 - /subversion/trunk/subversion/tests/svn_test_main.c

From: Ben Reser <ben_at_reser.org>
Date: Mon, 20 Jan 2014 13:05:10 -0800

On 12/2/13, 6:46 AM, stefan2_at_apache.org wrote:
> Author: stefan2
> Date: Mon Dec 2 14:46:11 2013
> New Revision: 1547035
>
> URL: http://svn.apache.org/r1547035
> Log:
> * subversion/tests/svn_test_main.c
> (main): Allow for testing compatibility with 1.7 and 1.8.
>
> Modified:
> subversion/trunk/subversion/tests/svn_test_main.c
>
> Modified: subversion/trunk/subversion/tests/svn_test_main.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test_main.c?rev=1547035&r1=1547034&r2=1547035&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/tests/svn_test_main.c (original)
> +++ subversion/trunk/subversion/tests/svn_test_main.c Mon Dec 2 14:46:11 2013
> @@ -788,7 +788,7 @@ main(int argc, const char *argv[])
> exit(1);
> }
> if ((opts.server_minor_version < 3)
> - || (opts.server_minor_version > 6))
> + || (opts.server_minor_version > 8))

Shouldn't this be opts.server_minor_version >= SVN_VER_MINOR so we don't have
to remember to update this everytime? Doesn't help if we change the major, but
the code already has that issue.
Received on 2014-01-20 22:05:51 CET

This is an archived mail posted to the Subversion Dev mailing list.