[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1544259 - /subversion/trunk/subversion/mod_dav_svn/repos.c

From: Ben Reser <ben_at_reser.org>
Date: Sun, 19 Jan 2014 23:36:34 -0800

On 11/21/13, 9:42 AM, brane_at_apache.org wrote:
> Author: brane
> Date: Thu Nov 21 17:42:41 2013
> New Revision: 1544259
> URL: http://svn.apache.org/r1544259
> Log:
> Return the correct error from mod_dav_svn if the repository path does not exist.
> * subversion/mod_dav_svn/repos.c (get_resource): If the reason for not being
> able to open a repositoy is ENOENT or ENOTDIR, then return a 404 status
> instead of 500.

This happens to have the side effect of making OPTIONS return a 404 when
running under SVNParentPath and the repo path doesn't exist. Technically I
don't think we should ever return an error to OPTIONS requests, but mod_dav_svn
doesn't provide us a way to say not to handle the OPTIONS request (and thus
fall back to httpd's default OPTIONS handler).

Not sure this is really a problem but thought I'd point out the possible HTTP
compliance issue here. I ran into this when I was doing some other work
lately, but decided I didn't care because this behavior already existed, just
noticed this commit today which introduced the behavior. Given that it's not
long standing behavior I'm not sure what we should do.
Received on 2014-01-20 08:37:17 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.