RE: prop edit: lost user edit bug
From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 24 Dec 2013 17:02:54 +0100
We have a baton in the callback, so no reason for bottle magic.
I found the other day that if my network fails for some reason
I took a look at the propedit code and found the following:
in subversion/svn/propedit-cmd.c in line 145 and 278 we call:
which lets the user write the prop but removes the file.
This function is defined in
In the function body, the variable tmpfile_left is actually never used
However, this assigned variable isn't used anywhere either, only
Callers of this function are located in
where in every case, tmpfile_left is seeded as NULL,
./svn/util.c:431: where it's called with an value that's carried via
struct log_msg_baton *lmb = log_msg_baton;
err = svn_cmdline__edit_string_externally(&msg_string,
I could change the calls in subversion/svn/propedit-cmd.c to give
Also, if the commit fails, the user would still not be informed where
I think the tmpfile_left could be changed to svn_boolean_t, and if
I'm not sure what to do next, would you have some advice for me
This is an archived mail posted to the Subversion Dev mailing list.