[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for programmer error in path split text logic

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 09 Dec 2013 16:29:58 +0000

Martin Furter <mf_at_apache.org> writes:

> I could also argue that it is inconsistent as long as you do not write
> *c as *(c+0).
> But this is irrelevant. As you found out the log message is wrong. So
> here is a honest one:
> [[[
> What led to at least one bug will probably lead to more bugs so remove
> the ugliness from the code to reduce the possibility of future bugs of
> this kind.
> ...
> ]]]

It's a style issue. I'm happy for you to change svn_path_splitext but
don't think we should change all the places you are proposing to change.

Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Received on 2013-12-09 17:30:35 CET

This is an archived mail posted to the Subversion Dev mailing list.