[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1548823 - in/subversion/trunk/subversion/libsvn_fs_x: dag.c id.c id.h temp_serializer.ctemp_serializer.h

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Sun, 8 Dec 2013 16:34:43 +0100

On Sun, Dec 8, 2013 at 1:31 PM, Bert Huijben <bert_at_qqmail.nl> wrote:

> We revved almost the entire wc api for Subversion 1.7, with almost no
> breakage for the older wc apis. (8 errata if I remember correctly). I don't
> see why we can't do this for the fs or ra layer APIs before 2.0. The old
> public APIs that miss arguments won't be as fast as the newer APIs that
> have them but... I don't see this as an excuse to use a bad design for the
> fs layer until 2.0.
>

Well, the alternative would be to eliminate svn_fs_id_t entirely from the
API,
which implies revving svn_fs_dirent_t and svn_fs_path_change2_t plus
related functions. Simply introducing svn_fs_id2_t in parallel to
svn_fs_id_t
would needlessly duplicate a lot of code exactly because the underlying
representations are incompatible.

I would actually like to remve svn_fs_id_t from the API since it violates
our general path_at_rev / path_at_root pattern (deprecating the old API for
backward compat). Any objections?

-- Stefan^2.
Received on 2013-12-08 16:35:20 CET

This is an archived mail posted to the Subversion Dev mailing list.