[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1548823 - in /subversion/trunk/subversion/libsvn_fs_x: dag.c id.c id.h temp_serializer.c temp_serializer.h

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Sun, 8 Dec 2013 11:52:16 +0100

On Sun, Dec 8, 2013 at 11:27 AM, Daniel Shahaf <d.s_at_daniel.shahaf.name>wrote:

> Stefan Fuhrmann wrote on Sun, Dec 08, 2013 at 11:09:47 +0100:> >
> >
> > Duly noted for Subversion 2.0
> >
> > For now, however, we have to implement id_vtable_t.
>
> Huh? id_vtable_t is not a public API. I assume the id vtable falls
> under the same rules as the fs_library vtable --- see
> fs_library_vtable_t.get_version's docstring.
>

True, but the following API simply don't provide any more information:

svn_fs_check_related(const svn_fs_id_t *a, const svn_fs_id_t *b)
svn_fs_compare_ids(const svn_fs_id_t *a, const svn_fs_id_t *b)

So, our private vtable depends on the data provided by public API.
Adding the pool member to the internal struct is exactly the way to
decouple the implementation from the existing public interface.

-- Stefan^2.
Received on 2013-12-08 11:53:17 CET

This is an archived mail posted to the Subversion Dev mailing list.