[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

AW: [PATCH] fix for programmer error in file equality check due to pointer logic

From: Markus Schaber <m.schaber_at_codesys.com>
Date: Fri, 6 Dec 2013 15:20:46 +0000

Hi,

I'm the author of said code, and feel ashamed that this bug slipped in.

The patch looks okay, and somehow I wonder that the code ever worked and passed the tests. :-(

Best regards

Markus Schaber

CODESYS® a trademark of 3S-Smart Software Solutions GmbH

Inspiring Automation Solutions

3S-Smart Software Solutions GmbH
Dipl.-Inf. Markus Schaber | Product Development Core Technology
Memminger Str. 151 | 87439 Kempten | Germany
Tel. +49-831-54031-979 | Fax +49-831-54031-50

E-Mail: m.schaber@codesys.com | Web: http://www.codesys.com | CODESYS store: http://store.codesys.com
CODESYS forum: http://forum.codesys.com

Managing Directors: Dipl.Inf. Dieter Hess, Dipl.Inf. Manfred Werner | Trade register: Kempten HRB 6186 | Tax ID No.: DE 167014915

> -----Ursprüngliche Nachricht-----
> Von: Eric Lubin [mailto:eric_at_lubin.us]
> Gesendet: Donnerstag, 5. Dezember 2013 21:22
> An: dev_at_subversion.apache.org
> Betreff: [PATCH] fix for programmer error in file equality check due to
> pointer logic
>
>
> [[[
> * subversion/libsvn_subr/io.c
> (contents_three_identical_p): Fixed incorrect pointer check against NULL,
> when the purpose was actually to check the value stored at that pointer for
> true or false ]]]
>
Received on 2013-12-06 16:21:31 CET

This is an archived mail posted to the Subversion Dev mailing list.