[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1547873 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 4 Dec 2013 20:09:58 +0100

On Wed, Dec 04, 2013 at 07:53:40PM +0100, Stefan Sperling wrote:
> On Wed, Dec 04, 2013 at 06:38:05PM -0000, philip_at_apache.org wrote:
> > @@ -1314,6 +1314,12 @@ svn_sqlite__hotcopy(const char *src_path
> > svn_sqlite__db_t *dst_db;
> > sqlite3_backup *backup;
> > int rc1, rc2;
> > + svn_node_kind_t kind;
> > +
> > + /* Create empty file first to avoid SQLITE_DEFAULT_FILE_PERMISSIONS. */
> > + SVN_ERR(svn_io_check_path(dst_path, &kind, scratch_pool));
> > + if (kind == svn_node_none)
> > + SVN_ERR(svn_io_file_create_empty(dst_path, scratch_pool));
> >
> > SVN_ERR(svn_sqlite__open(&dst_db, dst_path, svn_sqlite__mode_rwcreate,
> > NULL, 0, NULL, scratch_pool, scratch_pool));
> >
>
> Shouldn't this be using svn_io_copy_perms() instead, so that
> permissions used by the hotcopy source are replicated?

Done in r1547877.
Received on 2013-12-04 20:10:38 CET

This is an archived mail posted to the Subversion Dev mailing list.