[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1547460 - /subversion/trunk/subversion/tests/libsvn_repos/repos-test.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 3 Dec 2013 22:34:38 +0100

> -----Original Message-----
> From: stefan2_at_apache.org [mailto:stefan2_at_apache.org]
> Sent: dinsdag 3 december 2013 17:24
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1547460 -
> /subversion/trunk/subversion/tests/libsvn_repos/repos-test.c
>
> Author: stefan2
> Date: Tue Dec 3 16:23:54 2013
> New Revision: 1547460
>
> URL: http://svn.apache.org/r1547460
> Log:
> Make repos-test complete for pre-1.5 compat runs.
>
> * subversion/tests/libsvn_repos/repos-test.c
> (node_location_segments): Report skipped tests as such.
> (test_get_file_revs): Skip for pre-1.5 repos because the feature is
> not supported for them.
>
> Modified:
> subversion/trunk/subversion/tests/libsvn_repos/repos-test.c
>
> Modified: subversion/trunk/subversion/tests/libsvn_repos/repos-test.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_re
> pos/repos-test.c?rev=1547460&r1=1547459&r2=1547460&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/tests/libsvn_repos/repos-test.c (original)
> +++ subversion/trunk/subversion/tests/libsvn_repos/repos-test.c Tue Dec
> 3 16:23:54 2013
> @@ -2462,7 +2462,8 @@ node_location_segments(const svn_test_op
> /* Bail (with success) on known-untestable scenarios */
> if ((strcmp(opts->fs_type, "bdb") == 0)
> && (opts->server_minor_version == 4))
> - return SVN_NO_ERROR;
> + return svn_error_create(SVN_ERR_TEST_SKIPPED, NULL,
> + "not supported for BDB in SVN 1.4");
>
> /* Create the repository. */
> SVN_ERR(svn_test__create_repos(&repos, "test-repo-node-location-
> segments",
> @@ -3061,6 +3062,11 @@ test_get_file_revs(const svn_test_opts_t
> apr_hash_set(ht_reverse_results, &trunk_results[i].rev,
> sizeof(svn_revnum_t), &trunk_results[i]);
>
> + /* Check for feature support */
> + if (opts->server_minor_version && (opts->server_minor_version < 5))
> + return svn_error_create(SVN_ERR_TEST_SKIPPED, NULL,
> + "not supported in pre-1.5 SVN");

I don't understand why this isn't supported for 1.5 repositories?

The get_file_revs api is much older than 1.5. Just the mergeinfo awareness was added in 1.5.

Did you just mask a regression or is there some other problem?

        Bert
Received on 2013-12-03 22:35:16 CET

This is an archived mail posted to the Subversion Dev mailing list.