[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Specifying commit timestamps over RA

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Fri, 29 Nov 2013 18:29:06 +0400

On 27 November 2013 22:57, Philip Martin <philip.martin_at_wandisco.com> wrote:
> In 1.9 we have a new API svn_fs_commit_txn2 that allows 'svnadmin load'
> to create a revision with a specified timestamp rather than having to
> make a commit with the "wrong" date followed by a revision property
> change to set svn:date to the correct value. WANdisco are interested in
> making this feature available over RA so that it can be used for
> replication. svnsync could use such an implementation to avoid having
> to make an svn:date revision property change after each commit.
>
While I added svn_fs_commit_txn2() function I think it should not be
exposed through svn_repos_* and RA layer.

FS layer currently doesn't treat svn:date as special property except
commit. And for commit operation it just an option add timestamp
within lock to guarantee them strictly ordered. As far I remember
Michael C. Pilato said somewhere that this intentional FS layer
design.

Repos layer is different: it relies on svn:date order in functions
like svn_repos_dated_revision(). Repos layer has functions to load
repository dump, but this dump supposed to be created by
svn_repos_dump_fs() and have valid svn:date order. Adding option to
specify custom svn:date for new revision in svn_repos() layer will
break this invariant.

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-11-29 15:30:06 CET

This is an archived mail posted to the Subversion Dev mailing list.