[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Ensure full distribution description is printed in svn --version -v

From: Ben Reser <ben_at_reser.org>
Date: Sat, 23 Nov 2013 12:52:03 -0800

On 11/23/13 12:41 PM, Andreas Stieger wrote:
> found a string handling issue:
> $ svn --version -v
> [...]
> - openSUSE 12 (Mantis) [Linux 3.4.63-2.44-desktop]
> [...] ^^^
> This when "lsb_release -a" clearly contains:
> Description: openSUSE 12.2 (i586)
>
> Turns out stringbuf_split_key calculates the buffer length incorrectly,
> causing the distribution name to be cut off after the length of the
> label instead of the remaining string, in this case 11 characters. Patch
> attached.
>
> [[[
> Ensure full distribution description is printed in svn --version -v
>
> * subversion/libsvn_subr/sysinfo.c
> (stringbuf_split_key): fix buffer length calculation
> ]]]

Committed in r1544878 with my approval.
Received on 2013-11-24 11:19:17 CET

This is an archived mail posted to the Subversion Dev mailing list.