Re: Fwd: [PATCH] Fix for `svn patch` changing permissions of patched files

Cathy Fitzpatrick <cathy_at_cathyjf.com> writes:

> A close look at `svn_subst_copy_and_translate4` confirms that my guess
> was correct. If the file does not have an EOL property, then
> `svn_subst_copy_and_translate4` behaves as you say. If, however, it
> does have an EOL property, then the last thing that
> `svn_subst_copy_and_translate4` does is copy the file permissions from
> the file under /tmp to the final destination file (line 1818 of
> libsvn_subr/subst.c in r1544295). You are correct that it is the file
> with the correct permissions that is copied to the final destination,
> but then `svn_subst_copy_and_translate4` overwrites those permissions
> (if and only if the file has an EOL property). So that's why we were
> seeing different things.

That's ugly. I think svn_subst_copy_and_translate4 should have the same
effect on permissions irrespective of keywords, eol, etc. I'm not sure
which of the two behaviours is correct.

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*