[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1540590 - bad use of SVN_INT_ERR

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 20 Nov 2013 17:00:05 +0000 (GMT)

> URL: http://svn.apache.org/r1540590

> Added: subversion/trunk/subversion/libsvn_subr/object_pool.c
> ==============================================================================
[...]
> +/* Cleanup function called when an object_ref_t gets released.
> + */
> +static apr_status_t
> +object_ref_cleanup(void *baton)
> +{
> +  object_ref_t *object = baton;
> +  svn_object_pool__t *object_pool = object->object_pool;
> +
> +  SVN_INT_ERR(svn_mutex__lock(object_pool->mutex));

This doesn't do quite what you might think. (And it's doc string is not clear about this.) It also prints out the error message. I don't think that's what you want here.

[...]
> +  SVN_INT_ERR(svn_mutex__unlock(object_pool->mutex, NULL));

And again.

- Julian
Received on 2013-11-20 18:00:49 CET

This is an archived mail posted to the Subversion Dev mailing list.