[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1541793 - in /subversion/branches/1.8.x-r1541790: ./ subversion/mod_dav_svn/mod_dav_svn.c

From: Ben Reser <ben_at_reser.org>
Date: Thu, 14 Nov 2013 12:11:59 -0800

On 11/14/13 2:01 AM, Philip Martin wrote:
> Looking at that again, the code doesn't rely on repos_basename being
> valid when there is an error but it is checking for non-NULL. So it's
> still a bit odd that we are checking repos_basename when there is an
> error as it means this code relies on dav_svn_split_uri not setting
> repos_basename on error.
>
> I still think the test of repos_basename should be removed. If we need
> to test something then look for HTTP_FORBIDDEN in err.

Thanks a lot for the review. After talking with stefan2 on IRC I came up with
a much better way to deal with this.

I myself wasn't thrilled with what I had done.
Received on 2013-11-14 21:12:35 CET

This is an archived mail posted to the Subversion Dev mailing list.