[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1540590 - APR_SIZET_MAX is not defined

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Thu, 14 Nov 2013 17:50:31 +0100

On Wed, Nov 13, 2013 at 1:19 PM, Julian Foad <julianfoad_at_btopenworld.com>wrote:

> > URL: http://svn.apache.org/r1540590
>
> > Added: subversion/trunk/subversion/libsvn_subr/object_pool.c
> >
> ==============================================================================
> [...]
> > +svn_object_pool__create(...,
> > + apr_size_t min_unused,
> > + apr_size_t max_unused, ...)
> [...]
> > + /* paranoia limiter code */
> > +#if APR_SIZET_MAX > APR_UINT32_MAX
>
> My compiler says:
> warning: "APR_SIZET_MAX" is not defined
>
> Presumably that means this block of code is never compiled.
>

As it turns out, APR_SIZE_MAX can't be used either
nor anything based on sizeof(). So, I simply removed
the preprocessor code entirely in r1541924. Compilers
might complain about it being "always true" on 32 bit
machines.

-- Stefan^2.
<http://svn.apache.org/r1541924>
Received on 2013-11-14 17:51:06 CET

This is an archived mail posted to the Subversion Dev mailing list.