Re: [PATCH] svnlook.py: Make it usable as a library
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 13 Nov 2013 16:13:39 +0000 (GMT)
(I sound so grumpy. Let me try again.)
Thank you, Anatoly, for bothering to contribute your changes back to the community.
Your main changes look good and well commented. I like them and I've committed them.
It always makes it easier and thus more likely that someone will commit your patch if you supply a log message even for a simple change, but in this case I wrote one. (Afterwards, I saw that in GitHub you have a series of log messages for the changes that made up this patch, but even if I'd seen them earlier I would still have needed to combine them into a single Subversion-style message.)
It's also best to avoid unrelated changes in the same patch. In this case, I stripped out the changes that seemed to be unrelated. Apologies if I missed something important.
I (Julian Foad) wrote:
> Hi, anatoly.
This is an archived mail posted to the Subversion Dev mailing list.