File permission changes on commit

I'm looking at r1540417 nominated for backport to 1.8. The fix allows
me to remove group/world read and/or read/write access and not have it
restored by commit even when my umask allows it:

$ ls -l wc/f
-rw-r--r-- 1 pm pm 2 Nov 11 13:10 wc/f
$ chmod go-r wc/f
$ ls -l wc/f
-rw------- 1 pm pm 2 Nov 11 13:10 wc/f
$ echo xx >> wc/f
$ svn ci -mm wc
$ ls -l wc/f
-rw------- 1 pm pm 2 Nov 11 13:10 wc/f

There is similar code affecting the execute bit but the behaviour is a
bit different. If I remove both read and execute then commit doesn't
restore execute but if I just remove execute it gets restored:

$ ls -l wc/f
-rwxr-xr-x 1 pm pm 2 Nov 11 13:13 wc/f
$ chmod go-x wc/f
$ ls -l wc/f
-rwxr--r-- 1 pm pm 2 Nov 11 13:13 wc/f
$ echo xx >> wc/f
$ svn ci -mm wc
$ ls -l wc/f
-rwxr-xr-x 1 pm pm 2 Nov 11 13:13 wc/f

I'm not sure what behaviour we are trying to implement, is restoring
execute a bug?

-- 
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*