[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Error during 'svn export' over http with serf 1.3.1

From: Bert Huijben <bert_at_qqmail.nl>
Date: Fri, 25 Oct 2013 11:19:32 +0200

> -----Original Message-----
> From: Johan Corveleyn [mailto:jcorvel_at_gmail.com]
> Sent: maandag 21 oktober 2013 09:46
> To: Ivan Zhakov; Lieven Govaerts
> Cc: Bert Huijben; Subversion Development
> Subject: Re: Error during 'svn export' over http with serf 1.3.1

> I've lost track of the status of this issue. Does anyone know where it
> stands currently?
>
> Was an issue reported to zlib for the problem with the optimized assembly
> code?
>
> Was there anything else that could have been done (or has already been
> done) on the serf or svn side?
>
> Is it now recommended to turn off --enable-ml when building for
> Windows? Should this be enforced by the build scripts, as a workaround
> until the optimized zlib is fixed?

It is recommended to build with Serf 1.3.2 (=latest release).

This requires that you build both ZLib and Serf yourself before building
Subversion. Subversion was updated to support this scenario.

When building ZLib yourself you should *not* enable the assembly
optimizations that Subversion would do if you passed --enable-ml as the
assembly optimizations produce incorrect results when decompressing with
certain input sizes.

These issues are known in the ZLib issue tracker on Github, but as the ZLib
project somehow sees the optimizations as supported (Documented in the
standard makefile without any warning, etc.) and unsupported (implemented in
the contrib directory), nobody seems to care

The assembly code in ZLib is untouched for years, while the code that was
literally converted to assembler had many bug fixes over these same years.

[I still have an item on my TODO list to add a regression test to both Serf
and Subversion to detect these broken setups when running the tests on it.
I'm just looking for a smaller test sample that shows this problem]

        Bert
>
> --
> Johan
Received on 2013-10-25 11:20:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.