[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: 1.8.4 up for testing/signing

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 23 Oct 2013 15:02:58 +0200

> -----Original Message-----
> From: Ivan Zhakov [mailto:ivan_at_visualsvn.com]
> Sent: woensdag 23 oktober 2013 14:04
> To: Ben Reser
> Cc: Subversion Development
> Subject: Re: 1.8.4 up for testing/signing
>
> On 22 October 2013 23:36, Ben Reser <ben_at_reser.org> wrote:
> > The 1.8.4 release artifacts are now available for testing/signing.
> > Please get the tarballs from
> > https://dist.apache.org/repos/dist/dev/subversion
> > and add your signatures there. I plan to try and release on October
> > 29th so please try and get your votes/signatures in place by October 28th.
> >
> I cannot build Subversion 1.8.4 on Windows. First problem that I have
> to update scripts that was working fine for Subversion 1.8.3 to build
> zlib and serf externally, while it was compiled by Subversion before.
> Even after fixing this I get the following error:
> [[[
> [exec] ------ Build started: Project: libsvn_ra_dll,
> Configuration: Release Win32 ------
> [exec] Linking...
> [exec] LINK : fatal error LNK1181: cannot open input file 'ssleay32.lib'
> ]]]
>
>
> From what I see problem in gen_win.py:1095:
> [[[
> if self.serf_lib and dep.external_lib == '$(SVN_SERF_LIBS)':
> nondeplibs.append(serflib)
> if (self.serf_ver_maj, self.serf_ver_min) >= (1, 3):
> nondeplibs.append('ssleay32.lib')
> nondeplibs.append('libeay32.lib')
> ]]]
>
> So dependency to ssleay32.lib added, but OPENSS\out32dll is not added
> to library search path (fakelibdirs).
>
> This code introduced on branch in r1533874:
> [[[
> rhuijben 20.10.2013 14:41:47
> Merge ^/subversion/branches/1.8.x-serf-1.3+-windows from trunk
> manually,
> because our automatic merge script doesn't like the branch name.
>
> * ^/subversion/branches/1.8.x-serf-1.3+-windows
> Allow compiling against serf 1.3 and later on Windows
> Justification:
> Serf 1.3 brings a lot of fixes that we need for 1.8.x stability.
> Notes:
> The dependency handling on Windows was updated for 1.9+, so this
> needs a specific backport patch (r1517123)
> Votes:
> +1: rhuijben, brane, stefan2
>
> ../trunk/tools/dist/backport.pl: sh(256): (in 'the
> 1.8.x-serf-1.3+-windows branch') at
> ../trunk/tools/dist/backport.pl line 258, <STATUS> chunk 21.
> Warning summary
> ===============
>
> 1.8.x-serf-1.3+-windows
> (^/subversion/branches/1.8.x-serf-1.3+-windows[...]): sh(256):
> ]]]
>
> Please note that I'm using scripts that was working fine with previous
> versions. I think we should not release Subversion 1.8.4 until this
> situation will be resolved.

Then we have a conflict between the requirements of the serf and Subversion projects.

Before this patch Subversion requires a serf makefile and wants to build zlib itself.

While serf wants a pre-build zlib, and to build itself with scons, preferable before Subversion.

The out32dll directory points to a OpenSSL source location (And only to that of a DLL build, not a static build), while both Serf and Subversion document for many releases that the argument should point to an install location where the build type (Static vs Shared) doesn't matter.

Yes, your old situation may have worked, but as far as I can see not in a way that was promised to work by either recent Serf or recent Subversion.

If you put everything of openssl in the apr directories, things build ok... But we never promised that it works (and we never will).

For 1.9/trunk the dependency system is optimized to be in some ways stricter (Version checks, etc.), while in more ways relaxed: you can use output directories for all dependencies; no more source requirements.

        Bert
Received on 2013-10-23 15:03:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.