[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1533994 - in /subversion/trunk/subversion/libsvn_subr: cmdline.c win32_xlate.c win32_xlate.h

From: Branko Čibej <brane_at_wandisco.com>
Date: Mon, 21 Oct 2013 07:56:14 +0200

On 21.10.2013 07:48, Branko Čibej wrote:
> On 20.10.2013 23:35, rhuijben_at_apache.org wrote:
>> * subversion/libsvn_subr/cmdline.c
>> (includes): Add conio.h on Windows. Add win32_xlate.
>> (svn_cmdline_init): Detect if stdout and/or stderr are connected to the
>> console.
>> (svn_cmdline_fputs): Shortcut stdout/stderr to the console when possible.
>>
>> * subversion/libsvn_subr/win32_xlate.c
>> (includes): Add svn_private_config.h.
>> (svn_subr__win32_utf8_to_utf16): New function.
>
> Good call!
>
> Can you now please go through all the places (two or three, I think)
> where we're using the internal APR function that does the same thing,
> and use this one instead; then we can finally make the Windows build
> independent of APR sources.

$ grep -r arch/win32 subversion
subversion/bindings/javahl/native/JNIUtil.cpp:#include <arch/win32/apr_arch_utf8.h>
subversion/libsvn_subr/io.c:#include <arch/win32/apr_arch_file_io.h>

Both places use apr_conv_ucs2_to_utf8 and the inverse function, but io.c
also uses some internal APR logic to tell the difference between WInNT
and Win95. I'd vote for simply ripping any pending support for the
ancient non-Unicode Windows OS so that we can get rid of that, too.

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane_at_wandisco.com
Received on 2013-10-21 07:56:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.