[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1532193 - in /subversion/trunk/subversion: include/svn_io.h libsvn_fs_fs/cached_data.c libsvn_subr/stream.c tests/libsvn_subr/stream-test.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Tue, 15 Oct 2013 07:34:23 +0200

On 15.10.2013 07:29, stefan2_at_apache.org wrote:
> Author: stefan2
> Date: Tue Oct 15 05:29:39 2013
> New Revision: 1532193
> URL: http://svn.apache.org/r1532193
> Log:
> Introduce svn_stringbuf_from_stream() as symmetric counterpart to
> svn_stream_from_stringbuf() and use it in one place.

On general principles, I'd prefer not adding a public API if the
implementation happens to be used in only one place in our code. It
would be better IMO to make this a private function, and only expose it
to the public if we find a real need for it. We're allowed to use
private APIs between our own libraries, and our public API is already
far too verbose.

-- Brane

Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane_at_wandisco.com
Received on 2013-10-15 07:35:07 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.