Re: svn commit: r1527211 - /subversion/trunk/subversion/svnserve/svnserve.c

On 28.09.2013 21:08, Stefan Fuhrmann wrote:
> On Sat, Sep 28, 2013 at 8:48 PM, Ivan Zhakov <ivan_at_visualsvn.com
> <mailto:ivan_at_visualsvn.com>> wrote:
>
> On 28 September 2013 22:20, <stefan2_at_apache.org
> <mailto:stefan2_at_apache.org>> wrote:
> > Author: stefan2
> > Date: Sat Sep 28 18:20:00 2013
> > New Revision: 1527211
> >
> > URL: http://svn.apache.org/r1527211
> > Log:
> > Hopefully, make our BSD buildbot happy.
> >
> > * subversion/svnserve/svnserve.c
> > (serve_thread_t): say 'struct shared_pool_t' explicitly
> >
> What about "typedef struct shared_pool_t shared_pool_t" in .h file and
> declare "struct shared_pool_t { ... } " in .c file? I found this
> practice very useful for hide implementation in one module only.
>
>
> There is already a typedef for this in line 456 but the buildbot's GCC
> does not like it:

The typedef is in an "#if APR_HAS_THREADS" block, the use in line 529 is
not. Apparently the APR is not compiled with thread support.

I've always found that when "GCC doesn't like" code that looks perfectly
valid, it's a good idea to verify that the code is, in fact, valid.
Apparently it's not, this time.

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane_at_wandisco.com