[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1527211 - /subversion/trunk/subversion/svnserve/svnserve.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Sat, 28 Sep 2013 23:14:53 +0400

On 28 September 2013 23:08, Stefan Fuhrmann
<stefan.fuhrmann_at_wandisco.com> wrote:
> On Sat, Sep 28, 2013 at 8:48 PM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
>>
>> On 28 September 2013 22:20, <stefan2_at_apache.org> wrote:
>> > Author: stefan2
>> > Date: Sat Sep 28 18:20:00 2013
>> > New Revision: 1527211
>> >
>> > URL: http://svn.apache.org/r1527211
>> > Log:
>> > Hopefully, make our BSD buildbot happy.
>> >
>> > * subversion/svnserve/svnserve.c
>> > (serve_thread_t): say 'struct shared_pool_t' explicitly
>> >
>> What about "typedef struct shared_pool_t shared_pool_t" in .h file and
>> declare "struct shared_pool_t { ... } " in .c file? I found this
>> practice very useful for hide implementation in one module only.
>
>
> There is already a typedef for this in line 456 but the buildbot's GCC
> does not like it:
>
Pretty strange. May be gcc will be happier if we define "struct
shared_pool_s {}" and "typedef struct shared_pool_s shared_pool_t" ?

-- 
Ivan Zhakov
CTO | VisualSVN | http://www.visualsvn.com
Received on 2013-09-28 21:15:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.