Re: Log-addressing branch ready for review

On Tue, Sep 24, 2013 at 6:51 PM, Ivan Zhakov <ivan_at_visualsvn.com> wrote:

> On 23 August 2013 03:21, Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
> wrote:
> > Hi all,
> >
> > As of r1516665, work on this branch has been completed.
> > Please review. See the BRANCH-README for the list of
> > major changes.
> >
> > If there are no objections, I will merge the code in the week
> > of Sep 23th.
> >
> Hi Stefan,
>
> I have looked through the code but I'm not ready to put my +1 on it. I
> think this branch is a good candidate for the "three +1" policy
> discused some time ago.
>

Would you vote +1 under the 3-vote policy ("seems o.k. but more
independent review should take place")?

> BTW, why we are not going to implement this in the FSX only?
>

Because FSX is not going to be recommended for general before
2017 or so.

While being only moderately complex, the log-addressing feature
revitalizes FSFS development. For instance, it will allow us to
introduce new versions of existing item types (e.g. extended change
list information; move-aware noderevs) in the same repository as
old item types.

Of curse, FSFSv7 will also be massively faster for a wide range of
operations and will continue to benefit from optimizations such as
pre-fetching in future releases. Finally, it provides 100% checksum
coverage of the rev/pack file contents. The source of a corruption
becomes much easier to spot.

-- Stefan^2.
Received on 2013-09-24 19:36:58 CEST