Re: Moves in FSFS

On 18.09.2013 10:50, Branko Čibej wrote:
> Given all of the above, we're talking about the following algorithm for
> move of src to tgt (I'm ignoring parent change, for clarity):
>
> if src is lazy:
> make-mutable(src)
> else:
> make-mutable(dirname(src))
> modify-dir-list(dirname(src), basename(src), basename(tgt))
>
> All of that complication merely to avoid creating a new node-revision
> record. On top of the other issues (e.g., the move not being obvious
> from the txn record), I hardly think this optimization is worth the
> trouble. It doesn't actually gain us anything.

Oh, and all of the above does not take account of rebase-for-commit
(a.k.a libsvn_fs_base/tree.c:merge). I haven't looked closely at that
code, but wouldn't be surprised if the absence of a node-revision record
for the moved node would complicate that code.

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane_at_wandisco.com