RE: svn commit: r1523465 - /subversion/trunk/subversion/svnserve/svnserve.c
From: Bert Huijben <bert_at_qqmail.nl>
Date: Sun, 15 Sep 2013 20:43:43 +0200
Ah, I read the patch too fast.
In this snippet
+/* Clear and release the given connection POOL.
+ svn_error_t *err;
+ err = svn_mutex__lock(connection_pools_mutex);
+ if (err)
+ APR_ARRAY_PUSH(connection_pools, apr_pool_t *) = pool;
I automatically assumed the 'svn_pool_clear' was just a variable assignment,
Maybe we should fix the whitespace here to follow our usual layout?
From: Stefan Fuhrmann [mailto:stefan.fuhrmann_at_wandisco.com]
On Sun, Sep 15, 2013 at 8:07 PM, Bert Huijben <bert_at_qqmail.nl
> -----Original Message-----
Is this really the best way to do this?
Not sure. I'm open for suggestions.
Can't we create a subpool here? (Or do we also need multiple allocators,
No. Those pools will be used concurrently by their
In the implementation I see that the existing pools are re-used, but they
release_connection_pool() clears them.
Shouldn't we at least release the used memory (and thate) when handing back
This is an archived mail posted to the Subversion Dev mailing list.