[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1523465 - /subversion/trunk/subversion/svnserve/svnserve.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Sun, 15 Sep 2013 20:07:36 +0200

> -----Original Message-----
> From: stefan2_at_apache.org [mailto:stefan2_at_apache.org]
> Sent: zondag 15 september 2013 19:47
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1523465 -
> /subversion/trunk/subversion/svnserve/svnserve.c
>
> Author: stefan2
> Date: Sun Sep 15 17:46:36 2013
> New Revision: 1523465
>
> URL: http://svn.apache.org/r1523465
> Log:
> As it turns out, allocating memory from the OS in a multi-threaded
> environment is relatively costly. With APR pools, this happens
> every time we use a newly created root pool.
>
> Therefore, teach svnserve to recycle the connection pools, keeping
> those precious memory blocks allocated instead of disposing and
> re-allocating them.

Is this really the best way to do this?

Can't we create a subpool here? (Or do we also need multiple allocators, etc.)

In the implementation I see that the existing pools are re-used, but they are not *cleared* before re-use?

Shouldn't we at least release the used memory (and thate) when handing back the memory to the pool allocator?

        Bert
Received on 2013-09-15 20:08:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.