Re: upgrade_tests 7 FAIL when working directory has a "+" character

On Wed, Sep 04, 2013 at 11:50:49PM -0400, James McCoy wrote:
> This was with svn 1.7.9. I haven't had a chance to test newer
> versions, but looking through the code in trunk, it looks like it
> would still be a problem.

Confirmed, it reproduces in trunk:

Index: subversion/tests/cmdline/upgrade_tests.py
===================================================================
--- subversion/tests/cmdline/upgrade_tests.py (revision 1520363)
+++ subversion/tests/cmdline/upgrade_tests.py (working copy)
@@ -425,7 +425,7 @@ def simple_entries_replace(path, from_url, to_url)
 def basic_upgrade_1_0(sbox):
   "test upgrading a working copy created with 1.0.0"
 
- sbox.build(create_wc = False)
+ sbox.build(name='foo+', create_wc = False)
   replace_sbox_with_tarfile(sbox, 'upgrade_1_0.tar.bz2')
 
   url = sbox.repo_url

% ../runpytest upgrade basic_upgrade_1_0 2>&1 | head
W: lt-svn: subversion/libsvn_subr/path.c:119: svn_path_join_internal: Assertion `svn_path_is_canonical_internal(base, pool)' failed.

W: CMD: /home/danielsh/src/svn/t1/subversion/svn/svn upgrade 'svn-test-work/working_copies/foo+' --config-dir /home/danielsh/src/svn/t1/subversion/tests/cmdline/svn-test-work/local_tmp/config --password rayjandom --no-auth-cache --username jrandom terminated by signal 6
Received on 2013-09-05 19:33:24 CEST