[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1099094 - /subversion/trunk/subversion/libsvn_ra_serf/commit.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Wed, 28 Aug 2013 18:35:49 +0400

On Tue, Aug 27, 2013 at 6:45 PM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> Ivan Zhakov <ivan_at_visualsvn.com> writes:
>
>> On Tue, May 3, 2011 at 7:39 PM, <philip_at_apache.org> wrote:
>>> Author: philip
>>> Date: Tue May 3 15:39:55 2011
>>> New Revision: 1099094
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1099094&view=rev
>>> Log:
>>> Revert part of r1099044. Files still get closed explicitly, to
>>> avoid problems with too many open files, but the files will
>>> exist on disk for longer.
>>>
>>> * subversion/libsvn_ra_serf/commit.c
>>> (apply_textdelta): Go back to svn_io_file_del_on_pool_cleanup.
>>>
>> Hi Philip,
>>
>> Do you remember why you reverted delete on close approach? Did you
>> find any problems? Because currently file_baton pool is not cleared
>> until close_edit and temporary files remain on disk until commit
>> finishes.
>
> I don't recall the details, there was some discussion on IRC:
>
> http://colabti.org/irclogger/irclogger_log/svn-dev?date=2011-05-03#l123
>
> Bert suggested that r1099044 could cause files not to be deleted at
> all.
>
Bert refers to r712674 [1] -- 4 years old change in APR, so it should
not be issue now.

@Bert: Do you remember why temporary file could be not removed on file close?

[1] http://svn.apache.org/viewvc?view=revision&revision=r712674

-- 
Ivan Zhakov
Received on 2013-08-28 16:36:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.