Re: svn commit: r1099094 - /subversion/trunk/subversion/libsvn_ra_serf/commit.c
On Tue, Aug 27, 2013 at 6:45 PM, Philip Martin
> Ivan Zhakov <ivan_at_visualsvn.com> writes:
>> On Tue, May 3, 2011 at 7:39 PM, <philip_at_apache.org> wrote:
>>> Author: philip
>>> Date: Tue May 3 15:39:55 2011
>>> New Revision: 1099094
>>> URL: http://svn.apache.org/viewvc?rev=1099094&view=rev
>>> Revert part of r1099044. Files still get closed explicitly, to
>>> avoid problems with too many open files, but the files will
>>> exist on disk for longer.
>>> * subversion/libsvn_ra_serf/commit.c
>>> (apply_textdelta): Go back to svn_io_file_del_on_pool_cleanup.
>> Hi Philip,
>> Do you remember why you reverted delete on close approach? Did you
>> find any problems? Because currently file_baton pool is not cleared
>> until close_edit and temporary files remain on disk until commit
> I don't recall the details, there was some discussion on IRC:
> Bert suggested that r1099044 could cause files not to be deleted at
Bert refers to r712674  -- 4 years old change in APR, so it should
not be issue now.
@Bert: Do you remember why temporary file could be not removed on file close?
Received on 2013-08-28 16:36:42 CEST
This is an archived mail posted to the Subversion Dev