[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] create LC_MESSAGES directories and copy subversion.mo to the directories at compile time

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 23 Aug 2013 09:45:47 +0100 (BST)

Masaru Tsuchiyama wrote:

> Does anybody comment my patch?

Hi Masaru.

It's not clear what is the reason for these changes. Your log message needs to answer the question "Why?".

> Masaru Tsuchiyama wrote:
>> I attach a patch to create LC_MESSAGES directories and
>> copy subversion.mo files to the directories and do some extra works.
>>
>> [[[
>>
>> * build/generator/gen_win.py
>> (POFile.__init__) : set class member 'lang' to 'base'.
>>
>> * build/generator/templates/build_locale.ezt
>> () : change working directory by %~dp0 to make sure that the relative
>> paths, which are used in the bat file, are correct.

Saying "to make sure ... paths ... are correct" suggests that you have found cases where the paths are not correct -- in other words, a bug. Can you describe it?

>> () : create mo directory only if the directory doesn't exist,
>> to suppress a warning.

OK, good.

>> () : create LC_MESSAGES directories if they don't exist.
>> () : copy mo files to the LC_MESSAGES directories as subversion.mo
> files.

Are this last two changes adding new functionality, or what?

- Julian
Received on 2013-08-23 10:46:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.